Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31516/2/src/mainboard/google/kukui/Kconfig File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/#/c/31516/2/src/mainboard/google/kukui/Kconfig@6... PS2, Line 68: config SSPM_BIN_FILE
@Julius I requested this to be a Kconfig, in case if we need to create build target-specific SSPM fi […]
Okay, maybe I misunderstood the purpose of the SSPM. Are there board-specific bits encoded in the binary? I was hoping it would always be the same for the whole SoC? Can you explain what we expect here?
If the binary is board-specific, it would probably still make more sense to keep a well-known name, just make it 3rdparty/blobs/src/mainboard/... instead. Unless there are even differences between variants of the same board (e.g. flapjack and kukui)? Then, yes, it needs to be a Kconfig. Although maybe it should still just be the base filename in the Kconfig then.
Note that if you're just worried about some weird edge case where we'd want to have different SSPM versions between Chrome OS boards to isolate releases or something, we can always do that at the ebuild level. They should only be separate in upstream coreboot if we really think they'll need to be different long-term. (And if we're just not sure yet, we can always put it at the SoC level now and change later if necessary.)