Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36218 )
Change subject: sb/intel/i82801gx: Don't program CIR3 ......................................................................
sb/intel/i82801gx: Don't program CIR3
X4x likely does not properly init the DMI Virtual Channels, causing problems to this reg.
Change-Id: Ic2deeabc96c2097f3ded80d262af21d2009ce063 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/i82801gx/early_cir.c 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/36218/1
diff --git a/src/southbridge/intel/i82801gx/early_cir.c b/src/southbridge/intel/i82801gx/early_cir.c index 29791bb..8efbbd1 100644 --- a/src/southbridge/intel/i82801gx/early_cir.c +++ b/src/southbridge/intel/i82801gx/early_cir.c @@ -30,7 +30,10 @@ RCBA32(CG) = 1;
RCBA32(0x0088) = 0x0011d000; - RCBA16(0x01fc) = 0x060f; + /* CIR3, Private virtual channel routing, skip on x4x because of + issues. (likely needs to properly set up DMI virtual channel. */ + if (!CONFIG(NORTHBRIDGE_INTEL_X4X)) + RCBA16(0x01fc) = 0x060f; RCBA32(0x01f4) = 0x86000040; /* Although bit 6 is set, it is not read back */ RCBA32(0x0214) = 0x10030549;