Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )
Change subject: mb/ocp/deltalake: Add SMM console log level override
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Patch Set 1:
Another more generic option is to pass the console loglevel via relocatable module parameters to the SMM module? That way the logic of fetching the console loglevel is done in the ramstage but passed on to SMM.
Uploaded CB:49460 for review.
File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47006/comment/51d23e23_1ef10ce5
PS1, Line 63: default 7
The default should be 7 when DEBUG_SMI is set; and should be 4 when DEBUG_SMI is not set.
Default set to 0 and can be changed via VPD 'smm_log_levle', since we don't want to see SMM handler log in the OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73afc944fbd6c21e884397f3049bd363e2c1ce2c
Gerrit-Change-Number: 47006
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Comment-Date: Thu, 14 Jan 2021 11:02:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment