Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33671 )
Change subject: libpayload/usb: Increase USB request timeout to 5 s
......................................................................
Patch Set 6:
(3 comments)
this fails to build (and apparently we need more libpayload configs to test it on qa.c.o)
https://review.coreboot.org/c/coreboot/+/33671/6/payloads/libpayload/drivers...
File payloads/libpayload/drivers/usb/dwc2.c:
https://review.coreboot.org/c/coreboot/+/33671/6/payloads/libpayload/drivers...
PS6, Line 149: DWC2_SLEEP_TIME_US
DWC2_*
https://review.coreboot.org/c/coreboot/+/33671/6/payloads/libpayload/drivers...
PS6, Line 162: DWC_SLEEP_TIME_US
DWC_*
https://review.coreboot.org/c/coreboot/+/33671/6/payloads/libpayload/drivers...
PS6, Line 169: DWC_SLEEP_TIME_US
DWC_*
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33671
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53e3e67d893420e7c9e8b52c47dd0edb979e5468
Gerrit-Change-Number: 33671
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 03 Jul 2019 19:45:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment