Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86 ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45059/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45059/3//COMMIT_MSG@8 PS3, Line 8: : Remove stubs for psp_verstage and This was moved to the other patch.
https://review.coreboot.org/c/coreboot/+/45059/3/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/3/src/soc/amd/picasso/bootblo... PS3, Line 125: CONFIG_PSP_SHAREDMEM_BASE Would it be better to use the '_transfer_buffer' symbol here? It's based on the value in CONFIG_PSP_SHAREDMEM_BASE, so it's not a critical change, but might make more sense.
https://review.coreboot.org/c/coreboot/+/45059/3/src/soc/amd/picasso/bootblo... PS3, Line 132: CONFIG_PSP_SHAREDMEM_BASE Same idea here, but maybe use the symbol _psp_sharedmem_dram?