Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38824 )
Change subject: soc/intel/apollolake: Display apollolake platform information
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Is there a reason why this needs to be part of bootblock?
We have size constrains in bootblock anyway and on the other hand have a plenty of space in the ramstage? Wouldn't it be as useful in ramstage?
good point, right now its more over parity with other soc design we have where bootblock does report platform early.
But fare point to move those in romstage may be as these are sorts of information to have, nothing as such mandatory to have inside BB itself. Agree ?
Sure, romstage is OK as well OFC.
I just stumbled across this issue as the bootblock size was increased and I do not see a good reason for it in this context.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4edfeae7faee9f5f80698cf34b31fdcb066a813
Gerrit-Change-Number: 38824
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 17 Feb 2020 07:45:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment