Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32967
Change subject: soc/intel/baytrail: Extend the scope of the mrc_params ......................................................................
soc/intel/baytrail: Extend the scope of the mrc_params
This makes it easier to call the common_romstage code in a common place.
Change-Id: I58c5c376c51b48a7cb9b3bc79dd77e417c98d8ae Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/google/rambi/romstage.c M src/soc/intel/baytrail/include/soc/romstage.h 2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/32967/1
diff --git a/src/mainboard/google/rambi/romstage.c b/src/mainboard/google/rambi/romstage.c index eba8beb..c244c83 100644 --- a/src/mainboard/google/rambi/romstage.c +++ b/src/mainboard/google/rambi/romstage.c @@ -21,6 +21,8 @@ #include <soc/romstage.h> #include <variant/variant.h>
+static void *spd_ptr; + static void *get_spd_pointer(char *spd_file_content, int total_spds, int *dual) { int ram_id = 0; @@ -52,7 +54,8 @@ if (dual_channel_config & (1 << ram_id)) *dual = 1;
- return &spd_file_content[SPD_SIZE * ram_id]; + spd_ptr = &spd_file_content[SPD_SIZE * ram_id]; + return spd_ptr; }
void mainboard_romstage_entry(struct mrc_params *mrc_params) @@ -73,6 +76,7 @@
spd_content = get_spd_pointer(spd_file, spd_fsize / SPD_SIZE, &dual_channel); + mrc_params->mainboard.dram_data[0] = spd_content; if (dual_channel) mrc_params->mainboard.dram_data[1] = spd_content; diff --git a/src/soc/intel/baytrail/include/soc/romstage.h b/src/soc/intel/baytrail/include/soc/romstage.h index 4fceefb..ea6298b 100644 --- a/src/soc/intel/baytrail/include/soc/romstage.h +++ b/src/soc/intel/baytrail/include/soc/romstage.h @@ -26,7 +26,6 @@
void mainboard_romstage_entry(struct mrc_params *mrc_params); void romstage_common(struct mrc_params *mrc_params); - void raminit(struct mrc_params *mp, int prev_sleep_state); void gfx_init(void); void tco_disable(void);