Attention is currently required from: Jakub Czapiga.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51949 )
Change subject: lib: Add obvious definition for `calloc`
......................................................................
Patch Set 7:
(1 comment)
File tests/lib/malloc-test.c:
https://review.coreboot.org/c/coreboot/+/51949/comment/683c9f2f_f03a2c8e
PS7, Line 150: assert_true(*p == 0);
There is assert_int_equal(a, b) macro. Please use that instead.
Sure, I'm new to these unit tests 😉
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720
Gerrit-Change-Number: 51949
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 21:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment