[coreboot-gerrit] [XS] Change in coreboot[main]: commonlib/storage: Avoid build error when CONFIG_PCI is disabled

[Subrata Banik (Code Review)]

Attention is currently required from: Jayvik Desai, Kapil Porwal, Pranava Y N.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87092?usp=email )

Change subject: commonlib/storage: Avoid build error when CONFIG_PCI is disabled
......................................................................

Patch Set 3:

(1 comment)

File src/commonlib/storage/pci_sdhci.c:

https://review.coreboot.org/c/coreboot/+/87092/comment/b2edc988_b46939f4?usp... :
PS2, Line 5: #include <device/pci_def.h>
> > > This is already part of above header when CONFIG_PCI is enabled.
> >
> > The addition of pci_sdhci.c without depending on CONFIG_PCI causes issues when PCI kconfig is disabled, resulting in missing macro errors during compilation.
> > src/commonlib/storage/Makefile.mk:22:bootblock-y += pci_sdhci.c
> > src/commonlib/storage/Makefile.mk:27:verstage-y += pci_sdhci.c
> > src/commonlib/storage/Makefile.mk:32:romstage-y += pci_sdhci.c
> > src/commonlib/storage/Makefile.mk:37:postcar-y += pci_sdhci.c
> > src/commonlib/storage/Makefile.mk:42:ramstage-y += pci_sdhci.c
>
> Especially when `COMMONLIB_STORAGE` and other storage Kconfigs are selected without PCI Kconfig, we should see this issue.

check latest patchset