Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34123 )
Change subject: mb/lenovo/{t60,z61t}: Convert to variant board
......................................................................
Patch Set 3:
(2 comments)
Addressed comments and merged cosmetic changes from a previous commit.
https://review.coreboot.org/c/coreboot/+/34123/2/src/mainboard/lenovo/t60/Kc...
File src/mainboard/lenovo/t60/Kconfig:
https://review.coreboot.org/c/coreboot/+/34123/2/src/mainboard/lenovo/t60/Kc...
PS2, Line 1: confi
I wouldn't use a "baseboard" Kconfig symbol here, since there's no "baseboard" (just two boards with […]
Done
https://review.coreboot.org/c/coreboot/+/34123/2/src/mainboard/lenovo/t60/Kc...
PS2, Line 36: config DEVICETREE
There's no need to override this. […]
Done in a followup commit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a3076780ac5cf183235f06e4c56d0707bf5e6ca
Gerrit-Change-Number: 34123
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Aug 2019 15:44:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment