Attention is currently required from: Branden Waldner, Paul Menzel, Keith Hui.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41098 )
Change subject: mb/asus/p2b: Add ACPI support for p3b-f
......................................................................
Patch Set 14:
(2 comments)
File src/mainboard/asus/p2b/variants/p3b-f/suspend.asl:
https://review.coreboot.org/c/coreboot/+/41098/comment/667912df_3d5dd0a3
PS14, Line 60: off
nit: Capitalise the 'o' for consistency
https://review.coreboot.org/c/coreboot/+/41098/comment/ce7a90cb_2d676586
PS14, Line 165: POST code
Not sure if we have something to print out POST codes from ACPI. In C code, we have a rather nice organisation with (nearly) all POST codes defined as macros.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3736532df0efde4399fb36eb19df8db511fac6ea
Gerrit-Change-Number: 41098
Gerrit-PatchSet: 14
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Branden Waldner
scruffy99@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Branden Waldner
scruffy99@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Tue, 03 Jan 2023 07:00:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
