Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22988 )
Change subject: google/kahlee/variants/(kahlee/baseboard)/gpio.c: Convert GPIO table ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants... PS1, Line 145: FCH_GPIO_OUTPUT_VALUE Should this be replaced with OUTPUT_L? The way it's here, output is not enabled.
https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants... PS1, Line 148: FCH_GPIO_OUTPUT_VALUE Ditto.
https://review.coreboot.org/#/c/22988/1/src/mainboard/google/kahlee/variants... PS1, Line 226: FCH_GPIO_OUTPUT_VALUE Ditto.