Attention is currently required from: Angel Pons. Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52344 )
Change subject: mb/asus/p8z77-v_lx2: Add CMOS option support ......................................................................
Patch Set 2:
(6 comments)
File src/mainboard/asus/p8z77-v_lx2/Kconfig:
https://review.coreboot.org/c/coreboot/+/52344/comment/f6ba86c1_130c9015 PS1, Line 19: select HAVE_CMOS_DEFAULT
Please insert these options in alphabetical order
Done
File src/mainboard/asus/p8z77-v_lx2/cmos.default:
https://review.coreboot.org/c/coreboot/+/52344/comment/7e180718_00c72a4c PS1, Line 4: Enable
Use `Disable` here. […]
Done
File src/mainboard/asus/p8z77-v_lx2/cmos.layout:
https://review.coreboot.org/c/coreboot/+/52344/comment/5d9a130b_17d0997b PS1, Line 24: # coreboot config options: cpu
Dead comment
Done
https://review.coreboot.org/c/coreboot/+/52344/comment/501d6eb9_b14ed320 PS1, Line 40: 4 1 Normal
nit: renumber enum IDs to be sequential? (i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/52344/comment/e3a86908_a99302e7 PS1, Line 53: 9 0 AHCI : 9 1 IDE
Should be "AHCI, Compatible, Legacy" as per CB:39829
Done
https://review.coreboot.org/c/coreboot/+/52344/comment/e4fabfcc_a2ebad88 PS1, Line 61: 11 6 224M
This goes up to 16 (512 MiB), in 32 MiB increments
Done