Hannah W has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32842 )
Change subject: southbridge/intel/fsp_rangeley: Fix wrong parameters passed to outw
......................................................................
Patch Set 4:
Patch Set 4:
why don't you use read_pmbase16 and write_pmbase16 ?
(see src/southbridge/intel/common/pmbase.c )
Yes that can be done. Except the naming was confusing because
PMBASE in src/southbridge/intel/common/pmbase.c is actually ACPI base
“ABASE (ACPI_BASE_ADDRESS)—Offset 40h”
“PBASE (PMC_BASE_ADDRESS)—Offset 44h”
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c00413ce9b9b6a3d5691d71ade2b12b08538622
Gerrit-Change-Number: 32842
Gerrit-PatchSet: 4
Gerrit-Owner: hannah.williams@dell.com
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hannah.williams@dell.com
Gerrit-CC: Hannah W
tohannahwilliams@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 May 2019 20:48:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment