Attention is currently required from: Sathyanarayana Nujella, Furquan Shaikh, Paul Menzel, Subrata Banik, Sathya Prakash M R, Tim Wawrzynczak.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51510 )
Change subject: mb/google/brya: Enable display and DSP audio UPD
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51510/comment/24b10b8d_a6e29be9
PS5, Line 11: BUG=b:181219097
Can you please update this to: […]
Done
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/51510/comment/dee132a9_24798bc9
PS4, Line 63: pLinkTmode" = "HDA_TMODE_8T"
: register "PchHdaIDispLinkFre
Sathya, I think we are going to need to understand how these configs relate to platforms i.e. […]
Ack
https://review.coreboot.org/c/coreboot/+/51510/comment/ffe0a06f_1fc8efe1
PS4, Line 63: pLinkTmode" = "HDA_TMODE_8T"
: register "PchHdaIDispLinkFre
Sathya, I think we are going to need to understand how these configs relate to platforms i.e. […]
Ack
https://review.coreboot.org/c/coreboot/+/51510/comment/030fa8b7_0c46a6ed
PS4, Line 63: pLinkTmode" = "HDA_TMODE_8T"
: register "PchHdaIDispLinkFre
Sathya, I think we are going to need to understand how these configs relate to platforms i.e. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dab02bedb6df995b1efd27332d3aa26985e188e
Gerrit-Change-Number: 51510
Gerrit-PatchSet: 6
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Attention: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Wed, 21 Apr 2021 13:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment