Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40539 )
Change subject: tests: Add device/i2c-test test case
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40539/1/tests/device/i2c-test.c
File tests/device/i2c-test.c:
https://review.coreboot.org/c/coreboot/+/40539/1/tests/device/i2c-test.c@36
PS1, Line 36: {0, 0xA, { /* bus, slave */
nit: Rather than comments, we usually make struct initializers more readable like this:
...devs[] = {
{ .bus = 0, .slave = 0xa, .regs = {
{ .reg = 0x0, .data = 0xb },
...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2eeb565aacc724ae3b9f5c76ef4b98ef695416d6
Gerrit-Change-Number: 40539
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Apr 2020 22:04:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment