Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45168 )
Change subject: util/intelp2m: Update output format of generated gpio.h
......................................................................
Patch Set 2: Code-Review+1
LGTM. I'd still like to see an option added to output the consolidated coreboot macro uncommented though :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I760f4aadece786ea455fb7569f42e06fefce2b61
Gerrit-Change-Number: 45168
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Sep 2020 21:38:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment