Attention is currently required from: Angel Pons, Patrick Rudolph.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59521 )
Change subject: security/intel/txt/romstage.c: Unlock memory when SCLEAN not needed
......................................................................
Patch Set 3:
(1 comment)
File src/security/intel/txt/romstage.c:
https://review.coreboot.org/c/coreboot/+/59521/comment/cdb48166_3b2db152
PS3, Line 138: wrmsr(TXT_UNLOCK_MEMORY_MSR, msr);
I simply don't understand why this is needed. […]
I wasn't aware of the existence of the code under src/northbridge/intel/sandybridge/raminit.c
I just got the info from Patrick Rudolph in another patch today or yesterday. I may remove it here and just hope evey other uarch does it in FSP/MRC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd29d163a2310f0b574fc72d575f23088ab1d11d
Gerrit-Change-Number: 59521
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 22 Nov 2021 16:17:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment