Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31997 )
Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................
Patch Set 6:
(9 comments)
Patch Set 2:
(4 comments)
Nico and Richard,
Your findings have been implemented.
Regards, Francois
https://review.coreboot.org/#/c/31997/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31997/1/src/arch/x86/smbios.c@569 PS1, Line 569: if ((cpuid_eax(0) < 0xb) || !(leaf_b.eax | leaf_b.ebx | leaf_b.ecx | leaf_b.edx))
line over 80 characters
Done
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@606 PS2, Line 606: 0x0200
#define in smbios. […]
Done
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@607 PS2, Line 607: 0x0100
#define in smbios. […]
Done
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@609 PS2, Line 609: 255
maybe "#define BYTE_LIMIT 255" on smbios. […]
Done
https://review.coreboot.org/#/c/31997/2/src/arch/x86/smbios.c@611 PS2, Line 611: 255
BYTE_LIMIT?
Done
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c@569 PS4, Line 569: if ((cpuid_eax(0) < 0xb) ||
trailing whitespace
Done
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c@606 PS4, Line 606: u16 core_count = smbios_processor_core_or_thread_count(PROCESSOR_CORE_TYPE);
line over 80 characters
Done
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c@607 PS4, Line 607: u16 thread_count = smbios_processor_core_or_thread_count(PROCESSOR_THREAD_TYPE);
line over 80 characters
Done
https://review.coreboot.org/#/c/31997/5/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31997/5/src/arch/x86/smbios.c@608 PS5, Line 608: thread_count = smbios_processor_core_thread_count(PROCESSOR_THREAD_TYPE);
line over 80 characters
Done