Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35902 )
Change subject: soc/intel/apl,skl,cnl,icl: implement a PRMRR size selection algorithm ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/35902/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35902/4//COMMIT_MSG@18 PS4, Line 18: withing within
https://review.coreboot.org/c/coreboot/+/35902/4//COMMIT_MSG@23 PS4, Line 23: was is
https://review.coreboot.org/c/coreboot/+/35902/4//COMMIT_MSG@33 PS4, Line 33: Tested how?
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/cannonlake/me... File src/soc/intel/cannonlake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/cannonlake/me... PS4, Line 60: * Please add spaces around the operator.
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/common/block/... PS4, Line 328: valid valid sounds like a boolean to me. Maybe there is an other name? valid_size?
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/common/block/... PS4, Line 334: << Please add spaces around the operator.
https://review.coreboot.org/c/coreboot/+/35902/4/src/soc/intel/common/block/... PS4, Line 343: die("Unsupported PRMRR size limit!"); Add more information? Look in the devicetree or something similar? Also print the value of `MSR_PRMRR_VALID_CONFIG`?