[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/cmn/sa: Store TOM into the CMOS

[Arthur Heymans (Code Review)]

Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Kapil Porwal.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73273 )

Change subject: soc/intel/cmn/sa: Store TOM into the CMOS
......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/common/block/systemagent/memmap.c:

https://review.coreboot.org/c/coreboot/+/73273/comment/7714fc44_2de31437 
PS3, Line 13: #if CON
> > Why is the CPP needed?
>
> because not all SoC selecting IA common block also selects IA common base code, hence the declaration of this function was missing. You can follow the verified bot failure

Would it make sense to have SOC_INTEL_COMMON_BLOCK_SA select SOC_INTEL_COMMON_BASECODE so that this header is present? In this case the CPP code is not a problem but in general it's to be avoided as for instance variables can be used/unused depending on it and the compiler won't like that.