Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Kapil Porwal.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73273 )
Change subject: soc/intel/cmn/sa: Store TOM into the CMOS
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/systemagent/memmap.c:
https://review.coreboot.org/c/coreboot/+/73273/comment/7714fc44_2de31437
PS3, Line 13: #if CON
Why is the CPP needed?
because not all SoC selecting IA common block also selects IA common base code, hence the declaration of this function was missing. You can follow the verified bot failure
Would it make sense to have SOC_INTEL_COMMON_BLOCK_SA select SOC_INTEL_COMMON_BASECODE so that this header is present? In this case the CPP code is not a problem but in general it's to be avoided as for instance variables can be used/unused depending on it and the compiler won't like that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2569495570652c488096f6a29f58dd8f0103af9d
Gerrit-Change-Number: 73273
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 18:57:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment