[coreboot-gerrit] Change in coreboot[master]: amdfwtool: Take a config file instead of command line parameters

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )

Change subject: amdfwtool: Take a config file instead of command line parameters
......................................................................

Patch Set 56:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42859/56/src/soc/amd/stoneyridge/Ma... 
File src/soc/amd/stoneyridge/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42859/56/src/soc/amd/stoneyridge/Ma... 
PS56, Line 160: ###18- Check for SMU firmware2 named either *.sbin or *.csbin
              : ###    TODO: Remove *.sbin section after the blobs repo is updated.
              : SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE).csbin
              : SMUFIRMWARE2_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE)_FN.csbin
              : ifeq ("$(wildcard $(SMUFIRMWARE2_FILE))","")
              : SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE).sbin
              : SMUFIRMWARE2_FN_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_$(FIRMWARE_TYPE)_FN.sbin
              : endif
              : 
              : ifeq ("$(wildcard $(SMUFWM_FN_FILE))","")
              : SMUFWM_FN_FILE=
              : SMUFIRMWARE2_FN_FILE=
              : endif
this should probably stay in here, since it's not only used for the amdfwtool call, but also to put the SMU blobs into CBFS