Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33534 )
Change subject: vboot: relocate code to log and clear recovery mode switch ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33534/3/src/security/vboot/Makefile.inc File src/security/vboot/Makefile.inc:
https://review.coreboot.org/#/c/33534/3/src/security/vboot/Makefile.inc@91 PS3, Line 91: romstage-y += vboot_logic.c Everything else in vboot_logic is the "main" verification code that runs in verstage, so it seems odd to me to add something from a different stage there. I think bootmode.c or vboot_common.c would be better places for this.
https://review.coreboot.org/#/c/33534/3/src/security/vboot/vboot_logic.c File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/#/c/33534/3/src/security/vboot/vboot_logic.c@302 PS3, Line 302: ROMSTAGE_CBMEM_INIT_HOOK(vboot_log_and_clear_recovery_mode_switch) Only x86 devices have elog available in romstage. This needs to be done in ramstage. (And it should be done for the VBOOT_STARTS_IN_ROMSTAGE case as well, even if we didn't use to do that.)