[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add MMinfra driver support

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85188?usp=email )

Change subject: soc/mediatek/mt8196: Add MMinfra driver support
......................................................................

Patch Set 24:

(8 comments)

File src/soc/mediatek/mt8196/mminfra.c:

https://review.coreboot.org/c/coreboot/+/85188/comment/fc10ffde_cbda37c9?usp... :
PS23, Line 15: (u32 addr, u32 val)
> static void wait_for_write_done(u32 write_reg, u32 status_reg, u32 val)

Done

https://review.coreboot.org/c/coreboot/+/85188/comment/2ded3dbd_09f938c4?usp... :
PS23, Line 17: 	write32p(addr,val);
> > `space required after that ',' (ctx:VxV)` […]

Done

https://review.coreboot.org/c/coreboot/+/85188/comment/c072f00e_11da0607?usp... :
PS23, Line 18: 	if (!wait_us(TIMEOUT_US, read32p(addr)==val))
> > `spaces required around that '==' (ctx:VxV)` […]

Done

https://review.coreboot.org/c/coreboot/+/85188/comment/3797e61c_75ea7b44?usp... :
PS23, Line 19: 		die("Wait write done timeout \n");
> > `unnecessary whitespace before a quoted newline` […]

Done

https://review.coreboot.org/c/coreboot/+/85188/comment/67e2bc82_5b87b484?usp... :
PS23, Line 37: write32p(MMINFRA_MM0_GALS_PROT_TX_EN, 0xff);
             : 	wait_for_write_done(read32p(MMINFRA_MM0_GALS_PROT_TX_RDY), 0xff);
> just call wait_for_write_done

Done

https://review.coreboot.org/c/coreboot/+/85188/comment/a21d8de2_a8e077e1?usp... :
PS23, Line 38: read32p(MMINFRA_MM0_GALS_PROT_TX_RDY),
> just pass the address to `wait_for_write_done`.

Done

https://review.coreboot.org/c/coreboot/+/85188/comment/e4ecaf82_fafe1d50?usp... :
PS23, Line 40: EN
> RDY

Done

https://review.coreboot.org/c/coreboot/+/85188/comment/4894e8b0_5bca43df?usp... :
PS23, Line 53: EN
> RDY

Done