Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38495 )
Change subject: vc/amd/agesa/[...]/Proc/Mem: Fix uninitialized scalar variable ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38495/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38495/2//COMMIT_MSG@15 PS2, Line 15: Tested on : Lenovo G505s. Please put it on a separate line (with blank line between paragraphs).
https://review.coreboot.org/c/coreboot/+/38495/2/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f15tn/Proc/Mem/Tech/mtthrcSeedTrain.c:
https://review.coreboot.org/c/coreboot/+/38495/2/src/vendorcode/amd/agesa/f1... PS2, Line 508: (RxEnMemClkTested[ByteLane][MemClkCycle] ? RxEnMemClkSt[ByteLane][MemClkCycle] == TRUE : (TechPtr->ByteLaneError[ByteLane] && DlyWrittenToReg[ByteLane])) Do you know what this condition does? Moving the assignment out of the if statement changes logic, but I do not know if it’s intended. Why is 0x10 subtracted for example?