Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tioga Pass
......................................................................
Patch Set 8:
(1 comment)
Patch Set 7:
Patch Set 7:
(8 comments)
Patch Set 7: Code-Review+1
Please also upload the logs to the board status repository with `util/board_status/board_status.sh`.
Yes, let me do that!
Thank you for uploading it [1].
- coreboot logs are missing, as CBMEM console is disabled.
We will enable CBMEM console.
- The timestamps look quite confusing.
I am not sure why. This needs to be investigated.
- Do you know, why the revisions in the logs are marked dirty?
Because of submodules (in paticular 3rdparty/libgfxinit). I will need to sort this out.
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp...
File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/6/Documentation/mainboard/ocp...
PS6, Line 1: TiogaPass
Forgot to push the updated version?
Sorry, Angel. I did forget.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b
Gerrit-Change-Number: 40925
Gerrit-PatchSet: 8
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Wed, 10 Jun 2020 17:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment