19 Sep
2019
19 Sep
'19
9:04 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29477 )
Change subject: x86/smbios: Untangle system and board tables ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/29477/8/src/drivers/i2c/at24rf08c/K... File src/drivers/i2c/at24rf08c/Kconfig:
https://review.coreboot.org/c/coreboot/+/29477/8/src/drivers/i2c/at24rf08c/K... PS8, Line 1: DRIVERS_I2C_AT24RF08C
Seems unneeded and incomplete (I never updated the […]
Hah, turned out that it is needed after all. Without this change, SMBIOS_PROVIDED_BY_MOBO can't be selected by other boards because it depends on VENDOR_LENOVO.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c9c95a1307529c3137647a161a698a4c3daa0ae
Gerrit-Change-Number: 29477
Gerrit-PatchSet: 10
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 19 Sep 2019 12:04:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel richard.spiegel@silverbackltd.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment