build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46661 )
Change subject: sc7180: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46661/2/src/soc/qualcomm/sc7180/car... File src/soc/qualcomm/sc7180/carve_out.c:
https://review.coreboot.org/c/coreboot/+/46661/2/src/soc/qualcomm/sc7180/car... PS2, Line 15: memset(_modem_id, 0, REGION_SIZE(modem_id)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46661/2/src/soc/qualcomm/sc7180/car... PS2, Line 15: memset(_modem_id, 0, REGION_SIZE(modem_id)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46661/2/src/soc/qualcomm/sc7180/car... PS2, Line 18: switch (modem_id) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/46661/2/src/soc/qualcomm/sc7180/soc... File src/soc/qualcomm/sc7180/soc.c:
https://review.coreboot.org/c/coreboot/+/46661/2/src/soc/qualcomm/sc7180/soc... PS2, Line 21: if (soc_modem_carve_out(&start, &end)) { braces {} are not necessary for single statement blocks