Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40023 )
Change subject: mb/volteer: enable Early Command Training ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG@7 PS9, Line 7: Early Command Training
By the way, there is no public information on what ECT does. […]
My understanding is that early command training is a memory training algorithm that ensures all command lines are in sync with a clock by adding required delays. Unfortunately, I don't have more details and couldn't find a good reference.
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG@10 PS9, Line 10: Command Training since FSP v2527 supports ECT.
It looks like we misunderstand each other. I thought you meant: […]
Bug report(b:150357377) basically tracks the work required to move to a newer version of FSP. There are no details of ECT shared. My understanding is that ECT was not enabled early on because older FSP did not support it. However, with FSP versions 2527, it should be possible to enable ECT on TGL.