7 May
2021
7 May
'21
11:32 p.m.
Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Julius Werner, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53908 )
Change subject: mb/google/volteer: adjust the size for RO/RW mcache ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Maybe the best course of action is just to remove the global RW_PERCENTAGE default for Chrome OS (ma […]
Agree with you about the RW_PERCENTAGE. Doubling MCACHE_SIZE for x86 is going to probably come at the cost of more chipsets having to select `NO_CBFS_MCACHE` instead. Maybe the MCACHE_SIZE should default to 16K for ChromeOS x86 platforms?
--
To view, visit https://review.coreboot.org/c/coreboot/+/53908
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9552bc9fa5d36b1ca662c9da030ae7b137b60a8
Gerrit-Change-Number: 53908
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Zhuohao Lee zhuohao@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Zhuohao Lee zhuohao@chromium.org
Gerrit-Comment-Date: Fri, 07 May 2021 21:32:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment