Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33767 )
Change subject: src/soc/amd/picasso: Update UARTs ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33767/4/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/33767/4/src/soc/amd/picasso/Kconfig... PS4, Line 196: config CONSOLE_UART_BASE_ADDRESS I know this pre-exists, but do we really need it? It looks like this is a redunant definition that could easily be replaced with a function call and array in C source, then we would not need to list the addresses in Kconfig
I can see this is passed to SeaBIOS makefile, but SeaBIOS really should pickup the same informatio from coreboot tables / LB tags.