Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55493
to review the following change.
Change subject: MRC platforms: Fix MRC version printk format specifiers ......................................................................
MRC platforms: Fix MRC version printk format specifiers
The printed values are unsigned, and should be printed accordingly.
Change-Id: Ie5edce914c389c70460b1ed3390731e3568340dd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/raminit.c M src/northbridge/intel/sandybridge/raminit_mrc.c M src/soc/intel/broadwell/raminit.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/55493/1
diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c index 9660961..4537783 100644 --- a/src/northbridge/intel/haswell/raminit.c +++ b/src/northbridge/intel/haswell/raminit.c @@ -165,7 +165,7 @@
/* Print the MRC version after executing the UEFI PEI stage */ u32 version = mchbar_read32(MRC_REVISION); - printk(BIOS_DEBUG, "MRC Version %d.%d.%d Build %d\n", + printk(BIOS_DEBUG, "MRC Version %u.%u.%u Build %u\n", (version >> 24) & 0xff, (version >> 16) & 0xff, (version >> 8) & 0xff, (version >> 0) & 0xff);
diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index 43619cd..fc143f6 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -176,7 +176,7 @@
/* Print the MRC version after executing the UEFI PEI stage */ u32 version = mchbar_read32(MRC_REVISION); - printk(BIOS_DEBUG, "MRC Version %d.%d.%d Build %d\n", + printk(BIOS_DEBUG, "MRC Version %u.%u.%u Build %u\n", (version >> 24) & 0xff, (version >> 16) & 0xff, (version >> 8) & 0xff, (version >> 0) & 0xff);
diff --git a/src/soc/intel/broadwell/raminit.c b/src/soc/intel/broadwell/raminit.c index fccb20c..9db34be 100644 --- a/src/soc/intel/broadwell/raminit.c +++ b/src/soc/intel/broadwell/raminit.c @@ -130,7 +130,7 @@
/* Print the MRC version after executing the UEFI PEI stage. */ u32 version = mchbar_read32(MRC_REVISION); - printk(BIOS_DEBUG, "MRC Version %d.%d.%d Build %d\n", + printk(BIOS_DEBUG, "MRC Version %u.%u.%u Build %u\n", (version >> 24) & 0xff, (version >> 16) & 0xff, (version >> 8) & 0xff, (version >> 0) & 0xff);