Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28956 )
Change subject: src: Standardize PCI_DEV(0, 0x1f, 0) name
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/28956/5/src/southbridge/intel/ibexpeak/pch.h
File src/southbridge/intel/ibexpeak/pch.h:
https://review.coreboot.org/#/c/28956/5/src/southbridge/intel/ibexpeak/pch.h...
PS5, Line 110: #define LPC_DEV PCI_DEV(0, 0x1f, 0)
Should start with PCH_ as all other defines in this file
--
To view, visit
https://review.coreboot.org/28956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0be00e5e9c733bbeb863250bd51eea8d33f54300
Gerrit-Change-Number: 28956
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 08 Oct 2018 07:15:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No