Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38443 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38443/2//COMMIT_MSG@10
PS2, Line 10: it meet
This is really trivial. The information is there, it's readable, it's understandable. […]
Sorry, not sure how this got added twice - I certainly didn't mean to be that emphatic. I do appreciate the work to make commit messages better. Spelling, grammar, asking for clarification.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a2f059fbd5c89f897cfb46d1f7a82b0923edb17
Gerrit-Change-Number: 38443
Gerrit-PatchSet: 5
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Jan 2020 00:29:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment