Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40343 )
Change subject: commonlib/elog: add event log parsing tables
......................................................................
Patch Set 1:
Patch Set 1:
If you're moving things into commonlib, can you please actually move and not just copy? The whole point of commonlib is that it is shared between coreboot and other things so we don't need to keep the definitions twice.
No problem. I remember commonlib was BSD license where coreboot was GPL and that libpayload is BSD. Thought it may cause issues with licensing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b8f92f4aaf0e91244fcdec5a4da0ff843bbacda
Gerrit-Change-Number: 40343
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Apr 2020 10:03:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment