Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39499 )
Change subject: mb/facebook/monolith: Configure COMB to 0x3e8
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39499/1/src/mainboard/facebook/mono...
File src/mainboard/facebook/monolith/com_init.c:
https://review.coreboot.org/c/coreboot/+/39499/1/src/mainboard/facebook/mono...
PS1, Line 33: pnp_set_irq(SERIAL_DEV2, PNP_IDX_IRQ0, 3);
Both of these values are hardcoded because of the system requirement. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb462bad5f0594e0b5c8dea6e02cd42d58d999ab
Gerrit-Change-Number: 39499
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Mar 2020 09:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-MessageType: comment