Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46252 )
Change subject: mb/purism/librem_skl: Clean up FSP-M RCOMP settings
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46252/1/src/mainboard/purism/librem...
File src/mainboard/purism/librem_skl/romstage.c:
https://review.coreboot.org/c/coreboot/+/46252/1/src/mainboard/purism/librem...
PS1, Line 15: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig;
No, that would declare a read-only pointer and would not even build. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82b0997846d4ec40cf9b1a8ebfb1e881b194e078
Gerrit-Change-Number: 46252
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 14 Oct 2020 09:18:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment