Attention is currently required from: Jason Glenesk, Raul Rangel, Damien Zammit, Lee Leahy, Marshall Dawson, Tim Wawrzynczak, Angel Pons, Julius Werner, Andrey Petrov, Patrick Rudolph, Yu-Ping Wu, Felix Held.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62019 )
Change subject: timestamps: Rename timestamps to make names more consistent
......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
File src/commonlib/include/commonlib/timestamp_serialized.h:
https://review.coreboot.org/c/coreboot/+/62019/comment/3dd41630_39ed0e51
PS3, Line 39: TS_DEVICE_ENUMERATE = 30,
: TS_DEVICE_CONFIGURE = 40,
: TS_DEVICE_ENABLE = 50,
: TS_DEVICE_INITIALIZE = 60,
: TS_OPROM_INITIALIZE = 65,
: TS_OPROM_COPY_END = 66,
: TS_OPROM_END = 67,
: TS_DEVICE_DONE = 70,
: TS_CBMEM_POST = 75,
: TS_WRITE_TABLES = 80,
: TS_FINALIZE_CHIPS = 85,
: TS_LOAD_PAYLOAD = 90,
: TS_ACPI_WAKE_JUMP = 98,
: TS_SELFBOOT_JUMP = 99,
Can we somehow adapt these entries?
https://review.coreboot.org/c/coreboot/+/62019/comment/0f5cb503_31fc2fc2
PS3, Line 122: TS_CSE_FW_SYNC_START = 948,
: TS_CSE_FW_SYNC_END = 949,
:
Can someone from Intel tell, if we can change these names?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I533e32392224d9b67c37e6a67987b09bf1cf51c6
Gerrit-Change-Number: 62019
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 17 Feb 2022 11:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment