build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33107 )
Change subject: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33107/2/src/commonlib/include/commonlib/regi...
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/#/c/33107/2/src/commonlib/include/commonlib/regi...
PS2, Line 89: uint64_t (*mmio_addr)(const struct region_device *, struct region *);
function definition argument 'const struct region_device *' should also have an identifier name
https://review.coreboot.org/#/c/33107/2/src/commonlib/include/commonlib/regi...
PS2, Line 89: uint64_t (*mmio_addr)(const struct region_device *, struct region *);
function definition argument 'struct region *' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0b1ac927b8782cc99cd7f34d8bf5c4ef60b5570
Gerrit-Change-Number: 33107
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Gmeiner
christian.gmeiner@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 09:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment