Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36878 )
Change subject: sb/intel/common: Properly guard USB debug
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
Missing fsp_broadwell_de, that had it before, cf. `git show --stat 1d4bdda`.
(ICH4 really has EHCI, I had to check, now I feel old for some reason)
I figured it was bogus since it likely needs HAVE_USBDEBUG_OPTIONS to use 1d.0 instead of 1d.7 which is not present in devicetrees of boards using this target.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84c3401b9419f2878c2cfdf81147fa854018f9ae
Gerrit-Change-Number: 36878
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 16 Nov 2019 11:00:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment