28 Oct
2020
28 Oct
'20
8:07 p.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46861 )
Change subject: drivers/wifi/generic: Split wifi_generic_fill_ssdt into two functions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46861/1/src/drivers/wifi/generic/ac... File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/46861/1/src/drivers/wifi/generic/ac... PS1, Line 181: dev->chip_info
Actually, we cannot use `config_of()` because it dies if there is no config. […]
That was the part I deleted because I wasn't sure.. "unless it can't handle the lack of chip_info..." as I dislike the hidden die() behavior.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ab5e4684492ea3b1cf749e5b9e2008e7ec8fa28
Gerrit-Change-Number: 46861
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Oct 2020 18:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Duncan Laurie dlaurie@chromium.org
Gerrit-MessageType: comment