Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32614 )
Change subject: soc/skl/memmap: calculate mem size even if IGD undefined in devtree ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c File src/soc/intel/skylake/memmap.c:
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c@175 PS1, Line 175: dev_find_slot Please use pcidev_path_on_root().
We try to get rid of dev_find_slot() because its semantics are not well defined before device enumeration in ramstage (every bus is 0 before that).
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c@205 PS1, Line 205: root_dev `root_dev` reads a little odd here, because it's not the root of the devicetree. Not your fault, I find `SA_DEVFN_ROOT` irritating as well.
https://review.coreboot.org/#/c/32614/1/src/soc/intel/skylake/memmap.c@205 PS1, Line 205: dev_find_slot Please use pcidev_path_on_root().