13 Dec
2019
13 Dec
'19
3:09 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37667 )
Change subject: libpayload: Read from cbmem console ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... PS2, Line 79: cbmem_console_read
I'll probably call this cbmem_console_readback
Does it make more sense with char *cbmem_console_read(size_t *count), or even discard the 'count' argument since the '\0's are all removed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie324055f5fd8276f1d833fc9d04f60a792dbb9f6
Gerrit-Change-Number: 37667
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-CC: Ting Shen phoenixshen@chromium.org
Gerrit-Comment-Date: Fri, 13 Dec 2019 03:09:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment