3 Apr
2023
3 Apr
'23
10:20 p.m.
Attention is currently required from: Raul Rangel, Eric Lai, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74099 )
Change subject: mb/google/myst: Enable chromeOS EC ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/myst/Kconfig:
https://review.coreboot.org/c/coreboot/+/74099/comment/7ba205cf_2e16e3f1 PS5, Line 19: : config CHROMEOS : select EC_GOOGLE_CHROMEEC_SWITCHES
cool, looks like you have `VBOOT_STARTS_IN_BOOTBLOCK` set. […]
Review race condition...set, new change hadn't been uploaded yet
--
To view, visit https://review.coreboot.org/c/coreboot/+/74099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id18a311097d575973087eb92fd446a5c511f570e
Gerrit-Change-Number: 74099
Gerrit-PatchSet: 7
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 22:20:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Jon Murphy jpmurphy@google.com
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment