Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46984 )
Change subject: mb/purism/librem_cnl: Add new variant 'Librem Mini v2' ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46984/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46984/2//COMMIT_MSG@10 PS2, Line 10: Cometlake Nit: Comet Lake
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... File Documentation/mainboard/purism/librem_mini_v2.md:
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... PS2, Line 9: Cometlake Nit: Comet Lake
https://en.wikipedia.org/wiki/Comet_Lake_(microprocessor)
https://review.coreboot.org/c/coreboot/+/46984/2/Documentation/mainboard/pur... PS2, Line 58: `sudo ./cbmem -1 | grep 'ME:'` Do you want this on the same line in the result oder “as a box”?
I’d add blank lines around the command and intend it with four spaces.