Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )
Change subject: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively
......................................................................
Patch Set 4:
Patch Set 4:
DUT should be able to boot up from user side who gets this proto board with eMMC or SSD mounted.
- Considering to EVT, we still need to evaluate to boot up by 255.
[Peichao:] Sure, this CL has included this logic, we can bring up normally from eMMC or SSD when SKU ID is 255
If SKU ID is 255, the gpio.c doesn't set eMMC pins correct at least?
Has the offline chat with paichao about:
1. Although the eMMC GPIO NF setting is removed from early_gpio_table but it is originally in the gpio_table already so 255 can be with eMMC config from gpio_table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827e6f1420801d43e0eb4708b8b8ad1692ef7e9f
Gerrit-Change-Number: 35204
Gerrit-PatchSet: 4
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Guohui Zhou
guohui.zhou@bitland.corp-partner.google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Thu, 05 Sep 2019 08:04:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment