John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48556 )
Change subject: mb/google/zork/var/vilboz: enable use_external_48MHz_osc ......................................................................
Patch Set 9:
(9 comments)
https://review.coreboot.org/c/coreboot/+/48556/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48556/4//COMMIT_MSG@9 PS4, Line 9: Disable FCH_48MHZ_CLK_OUT for LTE sku in next build.
Will try mainboard_init as well. Not sure this value will be override by FSP. […]
Done
https://review.coreboot.org/c/coreboot/+/48556/4//COMMIT_MSG@13 PS4, Line 13:
add TEST here
Done
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/m... PS4, Line 244: if (board_id() > 2)
move to board level.
Done
https://review.coreboot.org/c/coreboot/+/48556/5/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48556/5/src/mainboard/google/zork/m... PS5, Line 165: FCH_48MHZ_CLK_OUT_INIT();
variant_mainboard_init
Done
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/v... PS4, Line 84: /* Disable FCH 48MHz clock for LTE SKU. */
change function name to variant_mainboard_final
Done
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/v... PS4, Line 8: vilboz_lte_sku
It would be good to start an issue for this request.
Done
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/v... PS4, Line 49: sku_id
Please do not use SKU IDs for feature differentiation. […]
Done
https://review.coreboot.org/c/coreboot/+/48556/4/src/mainboard/google/zork/v... PS4, Line 53: MISC_CLK_CNTL1
This register should not be touched directly by the mainboard. […]
Done
https://review.coreboot.org/c/coreboot/+/48556/1/src/soc/amd/picasso/fch.c File src/soc/amd/picasso/fch.c:
https://review.coreboot.org/c/coreboot/+/48556/1/src/soc/amd/picasso/fch.c@9... PS1, Line 94: ctrl &= ~BP_X48M0_OUTPUT_EN;
need move to board level.
Done