6 Apr
2021
6 Apr
'21
8:26 a.m.
Attention is currently required from: Kevin Chang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51623 )
Change subject: Lindar/Lillipup: Enable Bayhub SD card reader power-saving mode ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51623/comment/f329bb14_3776e397 PS4, Line 7: Lindar/Lillipup Please write it lowercase, and please follow the common style for variant prefixes.
https://review.coreboot.org/c/coreboot/+/51623/comment/d21e5be6_42a76cce PS4, Line 12: TEST=Boot to OS and test with SD card function. How did you test htis exactly?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I923d6e1beacd007c0e501f39c1f434c3e1085b9e
Gerrit-Change-Number: 51623
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Kevin Chang kevin.chang@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Tue, 06 Apr 2021 08:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment