build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38618 )
Change subject: mb/google/hatch: Override board_get_usb_typec_port_paths on Kohaku ......................................................................
Patch Set 1:
(13 comments)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 36: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 38: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 38: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 38: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 0 }}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 39: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 39: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 39: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 0 }}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 42: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 42: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 42: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 2, .port_id = 1 }}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 43: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 43: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}}, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38618/1/src/mainboard/google/hatch/... PS1, Line 43: {.type=DEVICE_PATH_USB, {.usb={ .port_type = 3, .port_id = 1 }}}, space required after that close brace '}'