Attention is currently required from: Ravi kumar, Sajida Bhanu, mturney mturney, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50583 )
Change subject: herobrine: Enable macronix SPI config
......................................................................
Patch Set 32: -Code-Review
(1 comment)
Patchset:
PS32:
Why Macronix? Are we planning to use that for Herobrine? (This would be the first I heard of us usin […]
Ok that's fair. I assumed that QC would know better but didn't verify because I didn't have the I/O board schematics for herobrine yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50583
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I505ee95d9f2ca16baf244135b3e2e8fe72f93491
Gerrit-Change-Number: 50583
Gerrit-PatchSet: 32
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Sajida Bhanu
sbhanu@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Sajida Bhanu
sbhanu@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 04 May 2021 05:23:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment